Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InputNumber: When using the InputNumber with the built in spinner buttons, "onValueChange" is called before "onChange". #3913

Closed
VentuzVictorPerez opened this issue Jan 4, 2023 · 4 comments · Fixed by #3916
Assignees
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone

Comments

@VentuzVictorPerez
Copy link

VentuzVictorPerez commented Jan 4, 2023

Describe the bug

Contrary to what is understood in the documentation, when using the InputNumber with the built in spinner buttons, the "onValueChange" event is called before the "onChange" event.

Reproducer

https://codesandbox.io/s/primereact-test-forked-mf67x0

PrimeReact version

8.7.3

React version

18.x

Language

TypeScript

Build / Runtime

Create React App (CRA)

Browser(s)

Chrome version 108.0.5359.125

Steps to reproduce the behavior

When interacting with the spinner buttons see in the console how "onValueChange" is called before "onChange" when it must be the other way around.

Expected behavior

"onChange" must be called before "onValueChange" as it happens if the built in spinner buttons are not used.

@VentuzVictorPerez VentuzVictorPerez added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jan 4, 2023
@melloware melloware added Type: Bug Issue contains a defect related to a specific component. and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jan 4, 2023
@melloware melloware self-assigned this Jan 4, 2023
@melloware melloware added this to the 8.7.4 milestone Jan 4, 2023
melloware added a commit to melloware/primereact that referenced this issue Jan 4, 2023
@melloware
Copy link
Member

Thanks for the report. PR submitted.

@VentuzVictorPerez
Copy link
Author

Thank you. Is there an estimate of when the next release will be?

@melloware
Copy link
Member

That is up to PrimeTek I am just a open source volunteer but they have been releasing about once a month if you look at prior history.

@VentuzVictorPerez
Copy link
Author

Okay, thanks, since you are a regular contributor I thought you were part of PrimeTek.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants