Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataTable: Correct "Select All" behavior in checkbox selection mode #4284

Closed
ulasturann opened this issue Apr 25, 2023 · 0 comments · Fixed by #4285
Closed

DataTable: Correct "Select All" behavior in checkbox selection mode #4284

ulasturann opened this issue Apr 25, 2023 · 0 comments · Fixed by #4285
Assignees
@ulasturann
Labels
Core Team Issue or pull request has been *opened* by a member of Core Team Type: Bug Issue contains a defect related to a specific component.
Milestone
9.3.1

Comments

@ulasturann
Copy link
Contributor

ulasturann commented Apr 25, 2023 •
edited
Loading

The "Select All" checkbox behavior in the DataTable component is incorrect. When there are no selectable items in the rows, the checkbox should not show as checked upon clicking it.

Reproducer

https://codesandbox.io/s/datatable-select-all-zdvvx9?file=/src/demo/DataTableSelectionDemo.js
@ulasturann ulasturann added the Core Team Issue or pull request has been *opened* by a member of Core Team label Apr 25, 2023
@ulasturann ulasturann added this to the 9.3.1 milestone Apr 25, 2023
@ulasturann ulasturann self-assigned this Apr 25, 2023
@github-actions github-actions bot added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Apr 25, 2023
@ulasturann ulasturann removed the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Apr 25, 2023
ulasturann added a commit that referenced this issue Apr 25, 2023
@ulasturann
Fix #4284: Correct Select All behavior in checkbox selection mode
21a3e5b
@ulasturann ulasturann mentioned this issue Apr 25, 2023
Merged
ulasturann added a commit that referenced this issue Apr 25, 2023
@ulasturann
Merge pull request #4285 from primefaces/issue-4284
ca3996c 
Fix #4284: Correct Select All behavior in checkbox selection mode
@ulasturann ulasturann added the Type: Bug Issue contains a defect related to a specific component. label Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ulasturann ulasturann

Labels
Core Team Issue or pull request has been *opened* by a member of Core Team Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Milestone
9.3.1
Development

Successfully merging a pull request may close this issue.

Fix #4284: Correct Select All behavior in checkbox selection mode primefaces/primereact
1 participant
@ulasturann