Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preventDefault() and stopPropagation() appear to be missing from drag and drop of DataTable - Reorder and causes redirect to 'www.b.com' #460

Closed
jelche opened this issue Jun 26, 2018 · 0 comments
Assignees
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone

Comments

@jelche
Copy link
Contributor

jelche commented Jun 26, 2018

I'm submitting a ... (check one with "x")

[ X ] bug report
[ ] feature request
[ ] support request => Please do not submit support request here, instead see https://forum.primefaces.org/viewforum.php?f=57

Current behavior
On drop of table row for reorder, page will re-direct to random page. I believe this is caused by not including the event.preventDefault() and event.stopPropegation() on the onDrop() event. Currently this only seems to be affecting Firefox.

Expected behavior
The expected outcome would be that it doesn't redirect on the drop event.

Minimal reproduction of the problem with instructions
To reproduce, use the drag and drop feature in the DataTable component with reorderableRows={true}. This is currently reproducible on the PrimeReact demo page as well (https://www.primefaces.org/primereact/#/datatable/reorder).

Please tell us about your environment:
HTTP Server: Apache
OS: RedHat/Fedora/Windows 7/10

  • React version:
    v16.4.0

  • PrimeReact version:
    v1.6.0

  • Browser:
    Mozilla Firefox v58.0.1

  • Language:
    ES6/7

@jelche jelche changed the title preventDefault() and stopPropegation() appear to be missing from drag and drop of TableRow and causes redirect preventDefault() and stopPropegation() appear to be missing from drag and drop of DataTable - Reorder and causes redirect to 'www.b.com' Jun 26, 2018
jelche added a commit to jelche/primereact that referenced this issue Jul 4, 2018
@cagataycivici cagataycivici changed the title preventDefault() and stopPropegation() appear to be missing from drag and drop of DataTable - Reorder and causes redirect to 'www.b.com' preventDefault() and stopPropagation() appear to be missing from drag and drop of DataTable - Reorder and causes redirect to 'www.b.com' Jul 18, 2018
@cagataycivici cagataycivici self-assigned this Jul 18, 2018
@cagataycivici cagataycivici added the Type: Bug Issue contains a defect related to a specific component. label Jul 18, 2018
@cagataycivici cagataycivici added this to the 2.0.0-beta.1 milestone Jul 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Development

No branches or pull requests

2 participants