Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OverlayPanel: Implement closeOnEscape props like in ConfirmDialog component #4750

Closed
alexdebiasio opened this issue Aug 8, 2023 · 2 comments · Fixed by #4705
Closed

OverlayPanel: Implement closeOnEscape props like in ConfirmDialog component #4750

alexdebiasio opened this issue Aug 8, 2023 · 2 comments · Fixed by #4705
Assignees
@melloware
Labels
Type: New Feature Issue contains a new feature or new component request
Milestone
10.0.0

Comments

@alexdebiasio
Copy link

alexdebiasio commented Aug 8, 2023 •
edited by melloware
Loading

Describe the feature you would like to see added

It would be great to have the closeOnEscape prop, which specify whether pressing escape key should hide the OverlayPanel.
It is already implemented in the ConfirmDialog component.
@alexdebiasio alexdebiasio added Status: Discussion Issue or pull request needs to be discussed by Core Team Type: New Feature Issue contains a new feature or new component request labels Aug 8, 2023
@github-actions github-actions bot added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Aug 8, 2023
@melloware melloware removed Status: Discussion Issue or pull request needs to be discussed by Core Team Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Aug 8, 2023
@melloware melloware self-assigned this Aug 8, 2023
@melloware melloware added this to the 10.0.0 milestone Aug 8, 2023
@melloware
Copy link
Member

melloware commented Aug 8, 2023 •
edited
Loading

@akshayaqburst can you add this to your PR please? #4705

@melloware melloware mentioned this issue Aug 8, 2023
Merged
akshayantony55 added a commit to qburst/primereact_qb that referenced this issue Aug 8, 2023
@akshayantony55
fix: primefaces#4750, Added closeOnEscape to Overlay panel
700e09f
melloware pushed a commit that referenced this issue Aug 9, 2023
@akshayaqburst @akshayantony55
Fix #4704: Image preview popup not closing on escape button click (#4705
1c97331 
)

* Fix primfaces#4704 Image preview popup not closing on escape button click

* Fix primfaces#4704 Resolved PR comments to run prettier

* Fix primfaces#4704 Added useOnEscape hook in Dialog to resolve PR comments

* Fix primfaces#4704 Reused the hook on dialog and sidebar components to resolve pr comments

* Fix primfaces#4704 Added params code to dialog escape event click to resolve pr comments

* renamed escape hook to resolve pr comments

* fix: #4750, Added closeOnEscape to Overlay panel

---------

Co-authored-by: akshayantony55 <akshayantony55@gmail.com>
@alexdebiasio
Copy link
Author

Hi @melloware , @akshayantony55 ,
thank you so much for the quick action!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

Labels
Type: New Feature Issue contains a new feature or new component request
Projects
None yet
Milestone
10.0.0
Development

Successfully merging a pull request may close this issue.

Fix #4704: Image preview popup not closing on escape button click qburst/primereact_qb
2 participants
@melloware @alexdebiasio