Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ConfirmDialog: appendTo prop is not working #4753

Closed
AndrewBoklashko opened this issue Aug 9, 2023 · 2 comments · Fixed by #4756
Closed

ConfirmDialog: appendTo prop is not working #4753

AndrewBoklashko opened this issue Aug 9, 2023 · 2 comments · Fixed by #4756
Assignees
@melloware
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone
10.0.0

Comments

@AndrewBoklashko
Copy link

Describe the bug

For ConfirmDialog component appendTo prop is not passed to the inner Dialog component, so it is always rendered under body.

image

Reproducer

https://codesandbox.io/s/primereact-confirmdialog-appendto-bug-xsmh3k

PrimeReact version

9.6.0

React version

18.x

Language

TypeScript

Build / Runtime

Create React App (CRA)

Browser(s)

Chrome 114

Steps to reproduce the behavior

See CodeSandbox and the screenshot above

Expected behavior

appendTo prop should work as expected for ConfirmDialog component, similarly as for Dialog component.
@AndrewBoklashko AndrewBoklashko added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Aug 9, 2023
@melloware melloware added Type: Bug Issue contains a defect related to a specific component. and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Aug 9, 2023
@melloware melloware self-assigned this Aug 9, 2023
@melloware melloware added this to the 10.0.0 milestone Aug 9, 2023
melloware added a commit to melloware/primereact that referenced this issue Aug 9, 2023
@melloware
Fix primefaces#4753: ConfirmDialog appendTo
aec0d05
@melloware melloware mentioned this issue Aug 9, 2023
Merged
@melloware
Copy link
Member

Good catch thanks for reporting!

melloware added a commit that referenced this issue Aug 9, 2023
@melloware
Fix #4753: ConfirmDialog appendTo (#4756)
bd63abb
@AndrewBoklashko
Copy link
Author

@melloware appreciate a quick fix 👍

@melloware melloware modified the milestones: 10.0.0, 9.7.0 Aug 21, 2023
@melloware melloware modified the milestones: 9.7.0, 10.0.0 Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Milestone
10.0.0
Development

Successfully merging a pull request may close this issue.

Fix #4753: ConfirmDialog appendTo melloware/primereact
2 participants
@melloware @AndrewBoklashko