Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calendar: disabledDays do affect year to be also disabled #4803

Closed
SlavaGeorgiev opened this issue Aug 21, 2023 · 1 comment · Fixed by #4804
Closed

Calendar: disabledDays do affect year to be also disabled #4803

SlavaGeorgiev opened this issue Aug 21, 2023 · 1 comment · Fixed by #4804
Assignees
@melloware
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone
10.0.0

Comments

@SlavaGeorgiev
Copy link

Describe the bug

When providing closedDays for calendar, some years are also disabled in calendar.

Check codesandbox https://codesandbox.io/s/primereact-demo-forked-h484y7?file=/src/App.js

closedDays = [0,6] results that e.g. 2036 is disabled?

Reproducer

https://codesandbox.io/s/primereact-demo-forked-h484y7?file=/src/App.js

PrimeReact version

9.6.0

React version

18.x

Language

TypeScript

Build / Runtime

Vite

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

closedDays do not affect year selection in Calendar.
@SlavaGeorgiev SlavaGeorgiev added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Aug 21, 2023
@SlavaGeorgiev SlavaGeorgiev changed the title Component: Calendar Calendar: closedDays do affect year to be also disabled Aug 21, 2023
melloware added a commit to melloware/primereact that referenced this issue Aug 21, 2023
@melloware
Fix primefaces#4803: Calendar disabledDays only in date display
dce7890
@melloware melloware added Type: Bug Issue contains a defect related to a specific component. and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Aug 21, 2023
@melloware melloware self-assigned this Aug 21, 2023
@melloware melloware added this to the 10.0.0 milestone Aug 21, 2023
@melloware melloware mentioned this issue Aug 21, 2023
Merged
melloware added a commit to melloware/primereact that referenced this issue Aug 21, 2023
@melloware
Fix primefaces#4803: Calendar disabledDays only in date display
1312618
@melloware melloware changed the title Calendar: closedDays do affect year to be also disabled Calendar: disabledDays do affect year to be also disabled Aug 21, 2023
@melloware
Copy link
Member

Good catch! Submitted a PR if you want to review.

melloware added a commit that referenced this issue Aug 21, 2023
@melloware
Fix #4803: Calendar disabledDays only in date display (#4804)
91a8286
@melloware melloware modified the milestones: 10.0.0, 9.7.0 Aug 21, 2023
@melloware melloware modified the milestones: 9.7.0, 10.0.0 Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Milestone
10.0.0
Development

Successfully merging a pull request may close this issue.

Fix #4803: Calendar disabledDays only in date display melloware/primereact
2 participants
@melloware @SlavaGeorgiev