Accordion: Documentation and Typescript definition do not match

[nrueckmann]

PrimeReactPTOptions defines a field accordiontab to set the passthrough oppions for the AccordionTab component (see

primereact/components/lib/api/api.d.ts

Line 300 in d8c7f7d

accordiontab?: AccordionTabPassThroughOptions;

)

export interface PrimeReactPTOptions {
    /**
     * Custom passthrough(pt) options for Accordion.
     */
    accordion?: AccordionPassThroughOptions;
    /**
     * Custom passthrough(pt) options for AccordionTab.
     */
    accordiontab?: AccordionTabPassThroughOptions;

But documentation (https://primereact.org/accordion/#tailwind) is using a field tab inside of AccordionPassThroughOptions.

It seems like the documentation is right, because PrimeReact does not catch up the accordiontab field if defined.

[melloware]

Actually accordiontab is right and tab is wrong. Let me fix.

[melloware]

PR submitted

[nrueckmann]

Thx, but it looks like your PR does not touch the type definitions which should be adjusted as well.

[melloware]

Which type defs do you refer?

[nrueckmann]

If i understand your PR right, you just changed the name of the field from tab to accordiontab. My initial issue was a different story:

PrimeReactPTOptions says it has a accordiontab field, but using it does not work.
AccordionPassThroughOptions says it does not have a tab or accordiontab field, but using it does work.

So the following documentation does not match the types:

const Tailwind = {  
    accordion: {
        root: 'mb-1',
        tab: {} // this field is not valid as AccordionPassThroughOptions does not have a field `tab` or `accordiontab`
    }
}

[melloware]

Yep it looks like tab/accordiontab has always been missing. Let me update.

[melloware]

OK updated my PR.

[melloware]

@nrueckmann it looks like this fix broken users again...

[melloware]

I see the issue