Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TreeSelect: emptyMessage not taken into account for filter #6408

Closed
MisterFISHUP opened this issue Apr 17, 2024 · 1 comment · Fixed by #6411 or leoo1992/GeradorQRCode#23
Closed

TreeSelect: emptyMessage not taken into account for filter #6408

MisterFISHUP opened this issue Apr 17, 2024 · 1 comment · Fixed by #6411 or leoo1992/GeradorQRCode#23
Assignees
@melloware
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone
10.6.4

Comments

@MisterFISHUP
Copy link

Describe the bug

The emptyMessage is not taken into account for filter.

Reproducer

https://stackblitz.com/edit/spsddb?file=src%2FApp.tsx

PrimeReact version

10.6.2

React version

18.x

Language

TypeScript

Build / Runtime

Create React App (CRA)

Browser(s)

No response

Steps to reproduce the behavior

  1. Write a TreeSelect with filter enabled, e.g. https://stackblitz.com/edit/spsddb?file=src%2FApp.tsx
  2. add emptyMessage props
  3. Type something in the filter input, the emptyMessage is No available options

Expected behavior

The message is the passed emptyMessage.
@MisterFISHUP MisterFISHUP added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Apr 17, 2024
@melloware melloware added Type: Bug Issue contains a defect related to a specific component. and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Apr 17, 2024
@melloware melloware self-assigned this Apr 17, 2024
@melloware melloware added this to the 10.6.4 milestone Apr 17, 2024
melloware added a commit to melloware/primereact that referenced this issue Apr 17, 2024
@melloware
Fix primefaces#6408: TreeSelect pass emptyMessage to Tree
b0cfdcd
@melloware melloware mentioned this issue Apr 17, 2024
Merged
@melloware
Copy link
Member

Thanks for the report PR submitted.

nitrogenous added a commit that referenced this issue Apr 25, 2024
@nitrogenous
Merge pull request #6411 from melloware/PR6408
a838bcc 
Fix #6408: TreeSelect pass emptyMessage to Tree
@leoo1992 leoo1992 mentioned this issue May 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Milestone
10.6.4
2 participants
@melloware @MisterFISHUP