Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCS: Use of deprecated Calendar - CalendarChangeEvent interface in docs #7218

Closed
qwadrox opened this issue Sep 19, 2024 · 4 comments · Fixed by #7223
Closed

DOCS: Use of deprecated Calendar - CalendarChangeEvent interface in docs #7218

qwadrox opened this issue Sep 19, 2024 · 4 comments · Fixed by #7223
Assignees
Labels
Component: Documentation Issue or pull request is related to Documentation
Milestone

Comments

@qwadrox
Copy link
Contributor

qwadrox commented Sep 19, 2024

Describe the bug

onChange={(e: CalendarChangeEvent)

return <Calendar value={options.value} onChange={(e: CalendarChangeEvent) => options.filterCallback(e.value, options.index)} dateFormat="mm/dd/yy" placeholder="mm/dd/yyyy" mask="99/99/9999" />;

Reproducer

No response

System Information

-

Steps to reproduce the behavior

No response

Expected behavior

No response

@qwadrox qwadrox added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Sep 19, 2024
@qwadrox
Copy link
Contributor Author

qwadrox commented Sep 19, 2024

Also on Advanced filtering: https://primereact.org/datatable/

@sja-cslab
Copy link
Contributor

Duplicate of #7208 which is fixed already

@qwadrox
Copy link
Contributor Author

qwadrox commented Sep 19, 2024

@sja-cslab This is a different file not the table filtering: primereact/components/doc/datatable/samples/customersdoc.js

But yes, the advanced filtering part has been fixed, but the current deployed version of the docs still not reflect the fix.

@melloware
Copy link
Member

Yep it will be fixed on next deployment. I will look for all instances of CalendarChangeevent and remove them

@melloware melloware self-assigned this Sep 19, 2024
@melloware melloware added Component: Documentation Issue or pull request is related to Documentation and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Sep 19, 2024
@melloware melloware added this to the 10.8.4 milestone Sep 19, 2024
melloware added a commit to melloware/primereact that referenced this issue Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Documentation Issue or pull request is related to Documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants