Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SplitButton: menu pass-through not working #7259

Closed
inad9300 opened this issue Sep 27, 2024 · 1 comment · Fixed by #7264
Closed

SplitButton: menu pass-through not working #7259

inad9300 opened this issue Sep 27, 2024 · 1 comment · Fixed by #7264
Assignees
@melloware
Labels
Component: Unstyled Issue related to unstyled/passthrough attributes
Milestone
10.8.4

Comments

@inad9300
Copy link
Contributor

inad9300 commented Sep 27, 2024 •
edited
Loading

Describe the bug

<SplitButton
  label='Save'
  model={[]}
  pt={{
    menu: { className: 'where-am-i' } // This class is not applied to the menu.
  }} />

Reproducer

https://stackblitz.com/edit/f8frzv?file=src%2FApp.jsx
@inad9300 inad9300 added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Sep 27, 2024
@melloware melloware added Component: Unstyled Issue related to unstyled/passthrough attributes and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Sep 27, 2024
melloware added a commit to melloware/primereact that referenced this issue Sep 27, 2024
@melloware
Fix primefaces#7259: SplitButton menu passthrough
98bc5bf
@melloware melloware self-assigned this Sep 27, 2024
@melloware melloware added this to the 10.8.4 milestone Sep 27, 2024
@melloware melloware mentioned this issue Sep 27, 2024
Merged
melloware added a commit to melloware/primereact that referenced this issue Sep 27, 2024
@melloware
Fix primefaces#7259: SplitButton menu passthrough
7d5d4b8
@melloware
Copy link
Member

Good catch its fixed but on next release you have to do .

pt={{ menu: { root: { className: 'where-am-i' } } }}

With the root and it will work since that is passing on to the TieredMenu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

Labels
Component: Unstyled Issue related to unstyled/passthrough attributes
Projects
None yet
Milestone
10.8.4
Development

Successfully merging a pull request may close this issue.

Fix #7259: SplitButton menu passthrough melloware/primereact
2 participants
@inad9300 @melloware