Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #4704: typescript order for closeOnEscape #4755

Merged
merged 1 commit into from
Aug 9, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions components/lib/image/image.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,11 @@ export interface ImageProps extends Omit<React.DetailedHTMLProps<React.HTMLAttri
* @readonly
*/
children?: React.ReactNode | undefined;
/**
* Specifies if pressing escape key should hide the preview.
* @defaultValue true
*/
closeOnEscape?: boolean | undefined;
/**
* The crossorigin content attribute on media elements is a CORS settings attribute.
*/
Expand Down Expand Up @@ -247,11 +252,6 @@ export interface ImageProps extends Omit<React.DetailedHTMLProps<React.HTMLAttri
* @defaultValue false
*/
unstyled?: boolean;
/**
* Specifies if pressing escape key should hide the preview.
* @defaultValue true
*/
closeOnEscape?: boolean | undefined;
}

/**
Expand Down
10 changes: 5 additions & 5 deletions components/lib/overlaypanel/overlaypanel.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,11 @@ export interface OverlayPanelProps extends Omit<React.DetailedHTMLProps<React.HT
* Icon to display as close icon.
*/
closeIcon?: IconType<OverlayPanelProps> | undefined;
/**
* Specifies if pressing escape key should hide the preview.
* @defaultValue true
*/
closeOnEscape?: boolean | undefined;
/**
* DOM element instance where the overlay panel should be mounted. Valid values are any DOM Element and 'self'. The self value is used to render a component where it is located.
* @defaultValue document.body
Expand Down Expand Up @@ -125,11 +130,6 @@ export interface OverlayPanelProps extends Omit<React.DetailedHTMLProps<React.HT
* @defaultValue false
*/
unstyled?: boolean;
/**
* Specifies if pressing escape key should hide the preview.
* @defaultValue true
*/
closeOnEscape?: boolean | undefined;
}

/**
Expand Down
Loading