Fix #5349: PanelMenu fix from PrimeVue #5359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melloware
added
the
Core Team
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
melloware
commented
Nov 21, 2023
| @@ -6,5 +6,6 @@ | |||
| "@/service/*": ["service/*"], | |||
| "@/data/*": ["data/*"] | |||
| } | |||
| } | |||
| }, | |||
| "exclude": ["../node_modules", "../dist"] | |||
There was a problem hiding this comment.
VSCode suggested that we ignore these large folders.
|
@melloware I would have worked on it! |
|
@melloware I just cloned this locally, and I did not see this working. Were you able to get the issue fixed with this change? |
|
Let me try your exact example |
|
Yes so... {
label: 'Edit',
icon: 'pi pi-fw pi-pencil',
items: []
},Looks like this.. And if you remove {
label: 'Edit',
icon: 'pi pi-fw pi-pencil',
},
Which is what @dy-xiaodong2022 is saying is the correct behavior. This fixes an extra border radius from being generated on an item with no values. |
xiaodong2008
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #5349: PanelMenu fix from PrimeVue
Ported fix from PrimeVue: https://github.com/primefaces/primevue/pull/4844/files