Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #5479: CascadeSelect PT fixes #5507

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Conversation

melloware
Copy link
Member

@melloware melloware commented Dec 2, 2023

Fix #5479: CascadeSelect PT fixes

@kl-nevermore @Dalorzo see my PR fixing these issues:

So for PTM you always have 3 objects context, state, props

export interface CascadeSelectPassThroughMethodOptions {
    props: CascadeSelectProps;
    state: CascadeSelectState;
    context: CascadeSelectContext;
}

So for your examples above in passthrough you will use.

label - use context.label to get the labels

item - use state.grouped and state.selected to determine if the item is active or in a group.

list and sublist - now have the proper context value which includes all API options like ripple and inputfilled etc.

Copy link

vercel bot commented Dec 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
primereact ⬜️ Ignored (Inspect) Visit Preview Dec 2, 2023 11:10pm
primereact-v9 ⬜️ Ignored (Inspect) Visit Preview Dec 2, 2023 11:10pm

@melloware melloware added the Core Team Issue or pull request has been *opened* by a member of Core Team label Dec 2, 2023
@melloware melloware force-pushed the PR5479 branch 2 times, most recently from 956d56e to f3f4342 Compare December 2, 2023 23:08
@kl-nevermore
Copy link
Contributor

I understand,The value of pt should be provided by those objects

@melloware melloware merged commit f1b9062 into primefaces:master Dec 4, 2023
6 checks passed
@melloware melloware deleted the PR5479 branch December 4, 2023 12:37
@melloware melloware mentioned this pull request Jan 9, 2024
88 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core Team Issue or pull request has been *opened* by a member of Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CascadeSelect: missing some values in pt
2 participants