Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#6274 - InputText: It doesnt take classNames when unstyled is true #6323

Merged
merged 2 commits into from
Apr 8, 2024
Merged

#6274 - InputText: It doesnt take classNames when unstyled is true #6323

merged 2 commits into from
Apr 8, 2024

Conversation

gucal
Copy link
Contributor

@gucal gucal commented Apr 8, 2024

#6274 - InputText: It doesnt take classNames when unstyled is true

@vercel Vercel
Copy link

vercel bot commented Apr 8, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
primereact ⬜️ Ignored (Inspect) Visit Preview Apr 8, 2024 11:51am
primereact-v9 ⬜️ Ignored (Inspect) Visit Preview Apr 8, 2024 11:51am

@gucal gucal linked an issue Apr 8, 2024 that may be closed by this pull request
InputText: It doesn't take classNames when unstyled is true #6274
Closed
@melloware
Copy link
Member

@gucal i think we need to remove prop.className from InputBase.js or else this will happen again: #6160

melloware
melloware requested changes Apr 8, 2024
View reviewed changes
Copy link
Member

@melloware melloware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment

@gucal
Copy link
Contributor Author

gucal commented Apr 8, 2024

@gucal i think we need to remove prop.className from InputBase.js or else this will happen again: #6160

Good catch. Thank you!

@gucal gucal requested a review from melloware April 8, 2024 11:53
@gucal gucal merged commit 860dff3 into primefaces:master Apr 8, 2024
4 of 5 checks passed
@peconomou929 peconomou929 mentioned this pull request Apr 8, 2024
Closed
30 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melloware melloware melloware approved these changes

@nitrogenous nitrogenous Awaiting requested review from nitrogenous

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

InputText: It doesn't take classNames when unstyled is true
2 participants
@gucal @melloware