Fix #6095 'dialog focus display none' #6434
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
KirilCycle
changed the title
|
@KirilCycle i think I know what is going on here let me do some testing! |
|
@melloware I found a new easier solution, we can use focusableElement.offsetParent !== null at 'getFocusableElements' method, this will prevent adding invisible elements to result array |
|
@KirilCycle see my PR. I fixed it how PrimeVue is doing it using the |
|
I am going to close this one in favor of my FocusTrap fix PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defect Fixes
Fix #6095
Focus Loop
PR implements a loop that iterates through an array of focusable elements. It keeps trying to focus on the next element until:
Note
Works fine with deep nested focusable elements in display none parent
Without 'onKeyDown' method tab pressing functions well
Video description:
Screen.Recording.2024-04-21.at.14.03.53.mov