Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix#6443 : Variable names fix #6444

Merged
merged 2 commits into from
Apr 22, 2024
Merged

Fix#6443 : Variable names fix #6444

merged 2 commits into from
Apr 22, 2024

Conversation

Rekl0w
Copy link
Contributor

@Rekl0w Rekl0w commented Apr 22, 2024

Fix #6443 : Variable names fix

Copy link

vercel bot commented Apr 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
primereact ⬜️ Ignored (Inspect) Visit Preview Apr 22, 2024 1:00pm
primereact-v9 ⬜️ Ignored (Inspect) Visit Preview Apr 22, 2024 1:00pm

@Rekl0w Rekl0w changed the title Fix#6443 : Fix#6443 : Variable names fix Apr 22, 2024
Copy link

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

1 similar comment
Copy link

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

@nitrogenous
Copy link
Contributor

Hey Batuhan, We appreciate your contributions and we are looking forward to see your helps. We usually trying to keep our demos sync with PrimeVue and in this case I kindly need to reject your pull request. You can check out the PrimeVue demo in below

https://primevue.org/tabview/#scrollable

@Rekl0w
Copy link
Contributor Author

Rekl0w commented Apr 22, 2024

I can sync this with PrimeVue's variables names. Can you open it again ? @nitrogenous

@nitrogenous nitrogenous reopened this Apr 22, 2024
@nitrogenous
Copy link
Contributor

Oh It's my fault this looks good to me. Thanks for your PR

@nitrogenous nitrogenous merged commit 6ef3a90 into primefaces:master Apr 22, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TabView: Variable names doesnt match at doc
2 participants