Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autocomplete Not able to delete a manually added chip #6474

Merged
merged 2 commits into from
Apr 29, 2024
Merged

Autocomplete Not able to delete a manually added chip #6474

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
53ec258
Removed If Condition
nitrogenous Apr 25, 2024
5ce886d
removed testing materials
nitrogenous Apr 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions components/lib/autocomplete/AutoComplete.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,11 +131,6 @@ export const AutoComplete = React.memo(
};

const updateModel = (event, value) => {
// #2176 only call change if value actually changed
if (selectedItem.current && ObjectUtils.deepEquals(selectedItem.current, value)) {
return;
}

if (props.onChange) {
props.onChange({
originalEvent: event,
Expand Down Expand Up @@ -257,7 +252,7 @@ export const AutoComplete = React.memo(
const removeItem = (event, index) => {
const removedValue = props.value[index];
const newValue = props.value.filter((_, i) => index !== i);

updateModel(event, newValue);

if (props.onUnselect) {
Expand Down
Loading