Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #6545: Remove setTokens in onPaste on InputOtp to avoid duplicate values #6526

Merged
merged 2 commits into from
May 2, 2024
Merged

Fix #6545: Remove setTokens in onPaste on InputOtp to avoid duplicate values #6526

merged 2 commits into from
May 2, 2024

Conversation

GabriellReis14
Copy link
Contributor

@GabriellReis14 GabriellReis14 commented Apr 30, 2024 •
edited by melloware
Loading

Fix #6545

  • When pasted the value into InputOtp, was duplicating the value, as the state was updated in onPaste and onInput

@datacampsis
Fix: Remove setTokens in onPaste on InputOtp to avoid duplicate values
321ed1e 
- When pasted the value into InputOtp, was duplicating the value, as the state was updated in onPaste and onInput
@vercel Vercel
Copy link

vercel bot commented Apr 30, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
primereact ⬜️ Ignored (Inspect) Visit Preview May 2, 2024 0:51am
primereact-v9 ⬜️ Ignored (Inspect) Visit Preview May 2, 2024 0:51am

@github-actions GitHub Actions
Copy link

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

@melloware
Copy link
Member

Please open a matching bug ticket

@GabriellReis14 GabriellReis14 changed the title Fix: Remove setTokens in onPaste on InputOtp to avoid duplicate values Fix #6545: Remove setTokens in onPaste on InputOtp to avoid duplicate values May 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 2, 2024

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

@melloware melloware added the Status: Pending Test Issue or pull request is being tested by Core Team label May 2, 2024
@melloware
Copy link
Member

I updated your PR to fix it a better way.

@melloware melloware added Type: Bug Issue contains a defect related to a specific component. and removed Status: Pending Test Issue or pull request is being tested by Core Team labels May 2, 2024
@melloware melloware merged commit db845e6 into primefaces:master May 2, 2024
4 checks passed
@GabriellReis14
Copy link
Contributor Author

I updated your PR to fix it a better way.

Nice! Thanks.

@leoo1992 leoo1992 mentioned this pull request May 24, 2024
Merged
@leoo1992 leoo1992 mentioned this pull request Jun 14, 2024
Merged
@raymondhtet raymondhtet mentioned this pull request Jun 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

InputOtp: When you paste a value into InputOtp, it is duplicating
3 participants
@GabriellReis14 @melloware @datacampsis