Fix:#6141:DataTable:Column: onCellEditComplete is fired twice

[kl-nevermore]

Fix #6141
Fix #6019
Fix #5556

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments

Name	Status	Preview	Comments	Updated (UTC)
primereact	⬜️ Ignored (Inspect)	Visit Preview		May 20, 2024 11:53am
primereact-v9	⬜️ Ignored (Inspect)	Visit Preview		May 20, 2024 11:53am

[didix16]

Hey @kl-nevermore, I think editingRowDataStateRef.current = getEditingRowData() should be added after line 522

primereact/components/lib/datatable/BodyCell.js

Lines 520 to 524 in 463ba5c

	useUpdateEffect(() => {
	if (props.editMode === 'cell' || props.editMode === 'row') {
	setEditingRowDataState(getEditingRowData());
	}
	}, [props.editingMeta]);

It should also update there the state ref, right?

Edit

Well it must be something like:

const editingRowData =  getEditingRowData();
setEditingRowDataState(editingRowData);
editingRowDataStateRef.current = editingRowData;

[kl-nevermore]

Yes, I missed this.
Maybe it would be better to use useeffect.

[melloware]

@kl-nevermore thanks for this let me know when its ready for review!

[kl-nevermore]

@melloware
I updated code, please review thanks!

[melloware]

This is a much better fix and removes the hack i added!