Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #6809: Make sure editable dropdown opens when user types #6810

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions DEVELOPMENT.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,9 @@ C:\primereact> npm run dev:link:windows

This will alter the bundler to only emit non-minified esm modules. The aliasing plugin has also been disabled for components. Once everything has been bundled (this can take a few minutes) you should keep this command running. It will allow for incremental builds as you develop in the `primereact/` directory.

> [!NOTE]
> It will be finished when the terminal displays: `[20xx-xx-xx 00:00:00] waiting for changes...`.
> Note: if you get "Error: JavaScript heap out of memory", it may help to set the following node variable: `export NODE_OPTIONS=--max-old-space-size=8192`.

> Note: The build will be finished when the terminal displays: `[20xx-xx-xx 00:00:00] waiting for changes...`.

You will now `cd` into the `primereact/dist` directory and run:

Expand Down
5 changes: 2 additions & 3 deletions components/doc/common/apidoc/index.json
Original file line number Diff line number Diff line change
Expand Up @@ -562,9 +562,8 @@
"type": "PrimeReactProviderProps"
},
{
"name": "deprecatedLegacyContext",
"type": "any",
"description": ""
"name": "context",
"type": "any"
}
],
"returnType": "ReactNode"
Expand Down
1 change: 1 addition & 0 deletions components/lib/dropdown/Dropdown.js
Original file line number Diff line number Diff line change
Expand Up @@ -654,6 +654,7 @@ export const Dropdown = React.memo(
};

const onEditableInputChange = (event) => {
!overlayVisibleState && show();
let searchIndex = null;

if (event.target.value && visibleOptions) {
Expand Down
Loading