Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #6862: change the order of applying default values to props #6879

Merged
merged 1 commit into from
Jul 13, 2024

Conversation

KumJungMin
Copy link
Contributor

@KumJungMin KumJungMin commented Jul 13, 2024

Defect Fixes

Fix #6862


how to resolve

  • This issue occurred in the PR(link) where the focusOnHover option was added to the orderList.
  • The {...props} spread operator is used to assign default values to props.
  • However, due to the order of {...props}, the default prop values were applied instead of the declared prop values, resulting in unexpected behavior.

Result

  • I tested two things in the modified code:

1. Whether focusOnHover works

2024-07-13.9.11.55.mov

2. Whether the filter function operates correctly

orderlist_filter_fix.mov

Copy link

vercel bot commented Jul 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
primereact ⬜️ Ignored (Inspect) Visit Preview Jul 13, 2024 0:05am
primereact-v9 ⬜️ Ignored (Inspect) Visit Preview Jul 13, 2024 0:05am

@KumJungMin KumJungMin changed the title fix: change the order of applying default values to props Fix #6862: change the order of applying default values to props Jul 13, 2024
@KumJungMin KumJungMin marked this pull request as ready for review July 13, 2024 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OrderList Filter Not Working
2 participants