Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #6855: ConfirmDialog group missing from typescript #7068

Merged
merged 1 commit into from
Aug 21, 2024
Merged

Fix #6855: ConfirmDialog group missing from typescript #7068

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions components/lib/confirmdialog/confirmdialog.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,10 @@ interface ConfirmDialogOptions {
* @group Properties
*/
export interface ConfirmDialogProps extends Omit<DialogProps, 'onHide' | 'footer' | 'pt'> {
/**
* Optional key to match the key of the confirmation, useful to target a specific confirm dialog instance.
*/
group?: string | undefined;
/**
* Unique tag key used to separate the confirmDialog components in the page.
*/
Expand Down
10 changes: 3 additions & 7 deletions components/lib/panelmenu/PanelMenu.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,13 +290,9 @@ export const PanelMenu = React.memo(
},
getPTOptions(item, 'headerSubmenuIcon', index)
);

const submenuIcon = item.items && IconUtils.getJSXIcon(
active
? (props.collapseIcon || <ChevronDownIcon {...headerSubmenuIconProps} />)
: (props.expandIcon || <ChevronRightIcon {...headerSubmenuIconProps} />)
);


const submenuIcon = item.items && IconUtils.getJSXIcon(active ? props.collapseIcon || <ChevronDownIcon {...headerSubmenuIconProps} /> : props.expandIcon || <ChevronRightIcon {...headerSubmenuIconProps} />);

const headerLabelProps = mergeProps(
{
className: cx('headerLabel')
Expand Down
8 changes: 2 additions & 6 deletions components/lib/panelmenu/PanelMenuSub.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,12 +185,8 @@ export const PanelMenuSub = React.memo(
getPTOptions(processedItem, 'submenuicon', index)
);

const submenuIcon = item.items && IconUtils.getJSXIcon(
active
? (props.collapseIcon || <ChevronDownIcon {...submenuIconProps} />)
: (props.expandIcon || <ChevronRightIcon {...submenuIconProps} />)
);

const submenuIcon = item.items && IconUtils.getJSXIcon(active ? props.collapseIcon || <ChevronDownIcon {...submenuIconProps} /> : props.expandIcon || <ChevronRightIcon {...submenuIconProps} />);

const submenu = createSubmenu(processedItem, active);
const actionProps = mergeProps(
{
Expand Down
Loading