Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct passthrough (pt) implementation for Stepperpanel. #7069

Merged
merged 3 commits into from
Aug 23, 2024

Conversation

Sumeet-2023
Copy link
Contributor

Ensured the pt (passthrough) mechanism properly applies Tailwind classes to the stepperpanel.
Example usage:
image
or
image

Defect Fixes

Fixes #6910

…pper components to use mergeProps for pt attributes.
Copy link

vercel bot commented Aug 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
primereact ⬜️ Ignored (Inspect) Visit Preview Aug 21, 2024 4:59pm
primereact-v9 ⬜️ Ignored (Inspect) Visit Preview Aug 21, 2024 4:59pm

@melloware
Copy link
Member

cc @gcko for review

@melloware melloware added the Component: Unstyled Issue related to unstyled/passthrough attributes label Aug 21, 2024
@melloware
Copy link
Member

can you also look at this one: #6758

Copy link
Member

@melloware melloware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run npm run format

@melloware melloware added the Status: Pending Review Issue or pull request is being reviewed by Core Team label Aug 21, 2024
@melloware
Copy link
Member

OK stepper unit tests are failing now because the HTML output has changed.

@Sumeet-2023
Copy link
Contributor Author

OK stepper unit tests are failing now because the HTML output has changed.

I had to add/remove attributes in HTML elements like data-pc-section in few components or changing/removing the ptm so that it affects DOM of Stepper/StepperPanel. Do i have to update unit test as well?

@melloware
Copy link
Member

yeah you can run npm test and then follow the instructions for how to update the snapshots.

@melloware melloware merged commit 91ce605 into primefaces:master Aug 23, 2024
5 checks passed
@Sumeet-2023
Copy link
Contributor Author

can you also look at this one: #6758

Sure! I was waiting for this PR to be merged. Now i can get started :)

@melloware
Copy link
Member

Thanks!

@melloware
Copy link
Member

@Sumeet-2023 i think we also need to update stepper.d.ts with the chnages in type styling for passthrough now too

@Sumeet-2023
Copy link
Contributor Author

@Sumeet-2023 i think we also need to update stepper.d.ts with the chnages in type styling for passthrough now too

Maybe i dont think so we need changes in .d.ts file because i made changes in such a way that .d.ts file wont be affected for Stepper component. Or I might have misinterpreted what u wanted to convey.

@melloware
Copy link
Member

AHH yes I see you are right the TypeScript was correct the code was wrong!

@Sumeet-2023 Sumeet-2023 deleted the fix/fixed-stepperpanel-pt branch August 23, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Unstyled Issue related to unstyled/passthrough attributes Status: Pending Review Issue or pull request is being reviewed by Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

StepperPanel: Pass Through "number" option not working
2 participants