Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Stepper): document undocumented start and end options, add types & improve #7128

Merged
merged 1 commit into from
Sep 8, 2024

Conversation

komachi
Copy link
Contributor

@komachi komachi commented Sep 7, 2024

Defect Fixes

Fix #7129

Stepper component has start and end options, it works, but it's undocumented and gives type errors. This PR fixes this (it also changes it from function to ReactNode to be consistent with Toolbar).

Copy link

vercel bot commented Sep 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
primereact ⬜️ Ignored (Inspect) Visit Preview Sep 7, 2024 10:19am
primereact-v9 ⬜️ Ignored (Inspect) Visit Preview Sep 7, 2024 10:19am

Copy link

github-actions bot commented Sep 7, 2024

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

@melloware melloware merged commit 202b78e into primefaces:master Sep 8, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stepper: start and end options are undocumented
2 participants