Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port reorder column from ngDataTable. #73

Closed
wants to merge 1 commit into from

Conversation

alwasa0b
Copy link

I ported the current reorder column functionality from the primeng project.

@mertsincan
Copy link
Member

Thank a lot for PR, @alwasa0b. I'll review and get back to you.

@alwasa0b
Copy link
Author

alwasa0b commented Aug 28, 2017

This seems to have broken the Column Toggler demo. That is because I am keeping a variable to hold the reordered columns within the DataTable.js. I am not sure how you want to go about that. I can think of few option to go about it.
First option, would be a callback function to update the column array with the new order when onDrop is done. Second option is to move the Multi-Select toggle to the DataTable.js. Lastly, require the column array to be passed for some of the functionalities to work.

@cagataycivici
Copy link
Member

Please monitor at #81

We can't merge it but will consult to it during our implementation which is very soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants