fix: #7330, AutoComplete: Selected item is not getting highlighted when visited again unlike Dropdown component #7331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lighted when visited again unlike Dropdown component
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
melloware
requested changes
Oct 11, 2024
| @@ -84,6 +85,10 @@ const styles = ` | |||
| padding: 0; | |||
| list-style-type: none; | |||
| } | |||
|
|
|||
| .selected { | |||
There was a problem hiding this comment.
Selected is weird should it be p-selected or is this what the other component does?
There was a problem hiding this comment.
I can change it.
There was a problem hiding this comment.
Changed to p-highlight similar to dropdown component.
…lighted when visited again unlike Dropdown component
melloware
requested changes
Oct 11, 2024
| @@ -86,7 +86,7 @@ const styles = ` | |||
| list-style-type: none; | |||
| } | |||
|
|
|||
| .selected { | |||
| .p-highlight { | |||
| background-color: rgba(6, 182, 212, 0.24) !important; | |||
There was a problem hiding this comment.
Removed the style added for p-highlight as a default style was already applied for autocomplete p-highlight class, and its working as expected.
…lighted when visited again unlike Dropdown component
melloware
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defect Fixes
fix: #7330, AutoComplete: Selected item is not getting highlighted when visited again unlike Dropdown component