Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datatable: Allow ignore of data-tag in CellEdit outside click #7439

Closed

Conversation

gnawjaren
Copy link
Contributor

Defect Fixes

Overlay Editors behave different when in CellEdit mode. This PR adds a workaround - adding the attribute
data-pr-is-overlay:true to the overlay excludes it from the onClickOutside handler.
This could be extended by adding it to the overlay editors by default.
We could then even remove the setTimeout.
It also works für third party editors.
#7405 #2097

Copy link

vercel bot commented Nov 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Updated (UTC)
primereact ⬜️ Ignored (Inspect) Visit Preview Nov 20, 2024 5:09pm
primereact-v9 ⬜️ Ignored (Inspect) Visit Preview Nov 20, 2024 5:09pm

@gnawjaren gnawjaren changed the title Allow ignore of data-tag in CellEdit outside click Datatable: Allow ignore of data-tag in CellEdit outside click Nov 20, 2024
AlexanderZeilmann pushed a commit to AlexanderZeilmann/primereact that referenced this pull request Nov 22, 2024
@gnawjaren
Copy link
Contributor Author

It seems to work fine in 10.8.5

@gnawjaren gnawjaren closed this Dec 6, 2024
@melloware melloware added this to the 10.8.5 milestone Dec 6, 2024
@melloware melloware added the Type: Bug Issue contains a defect related to a specific component. label Dec 6, 2024
@melloware melloware removed this from the 10.8.5 milestone Dec 6, 2024
@melloware melloware removed the Type: Bug Issue contains a defect related to a specific component. label Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants