Merge pull request #4544 from FlipWarthog/PV4543

Fix #4543: Column: headercheckboxicon slot not working
primefaces · Oct 4, 2023 · 6652492 · 6652492
2 parents 4776718 + 2173790
commit 6652492
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 12 deletions.
diff --git a/components/lib/datatable/DataTable.vue b/components/lib/datatable/DataTable.vue
@@ -87,7 +87,6 @@
                             :filtersStore="filters"
                             :filterDisplay="filterDisplay"
                             :filterInputProps="filterInputProps"
-                            :headerCheckboxIconTemplate="$slots.headercheckboxicon"
                             @column-click="onColumnHeaderClick($event)"
                             @column-mousedown="onColumnHeaderMouseDown($event)"
                             @filter-change="onFilterChange"

diff --git a/components/lib/datatable/HeaderCell.vue b/components/lib/datatable/HeaderCell.vue
@@ -35,7 +35,7 @@
                 :checked="allRowsSelected"
                 @change="onHeaderCheckboxChange"
                 :disabled="empty"
-                :headerCheckboxIconTemplate="headerCheckboxIconTemplate"
+                :headerCheckboxIconTemplate="column.children && column.children.headercheckboxicon"
                 :column="column"
                 :pt="pt"
             />
@@ -181,10 +181,6 @@ export default {
         filterInputProps: {
             type: null,
             default: null
-        },
-        headerCheckboxIconTemplate: {
-            type: Function,
-            default: null
         }
     },
     data() {

diff --git a/components/lib/datatable/TableHeader.vue b/components/lib/datatable/TableHeader.vue
@@ -36,7 +36,6 @@
                         @constraint-add="$emit('constraint-add', $event)"
                         @constraint-remove="$emit('constraint-remove', $event)"
                         @apply-click="$emit('apply-click', $event)"
-                        :headerCheckboxIconTemplate="headerCheckboxIconTemplate"
                         :pt="pt"
                     />
                 </template>
@@ -119,7 +118,6 @@
                         @constraint-add="$emit('constraint-add', $event)"
                         @constraint-remove="$emit('constraint-remove', $event)"
                         @apply-click="$emit('apply-click', $event)"
-                        :headerCheckboxIconTemplate="headerCheckboxIconTemplate"
                         :pt="pt"
                     />
                 </template>
@@ -226,10 +224,6 @@ export default {
         filterInputProps: {
             type: null,
             default: null
-        },
-        headerCheckboxIconTemplate: {
-            type: Function,
-            default: null
         }
     },
     methods: {