Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ConfirmDialog: 'position' TypeScript errors #2381

Closed
CA-Drew opened this issue Mar 31, 2022 · 0 comments
Closed

ConfirmDialog: 'position' TypeScript errors #2381

CA-Drew opened this issue Mar 31, 2022 · 0 comments
Assignees
@tugcekucukoglu
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
3.12.5

Comments

@CA-Drew
Copy link

CA-Drew commented Mar 31, 2022

I'm submitting a ... (check one with "x")

[x] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primevue/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=110

Current behavior
If you try to specify position in confirm.require you will get typescript errors, preventing compilation.

Expected behavior
The position property should be accepted (it does work if added to the type file).

Please tell us about your environment:

  • Vue version: 3.2.25
  • PrimeVue version: 3.12.2
  • Vite version: 2.8.0
  • TypeScript version: 4.5.4
@tugcekucukoglu tugcekucukoglu added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Mar 31, 2022
@tugcekucukoglu tugcekucukoglu added this to the 3.12.4 milestone Apr 4, 2022
@tugcekucukoglu tugcekucukoglu self-assigned this Apr 4, 2022
@tugcekucukoglu tugcekucukoglu changed the title ConfirmDialog: 'position' property missing from ConfirmationOptions.d.ts, causing TypeScript errors ConfirmDialog: 'position' TypeScript errors Apr 4, 2022
tugcekucukoglu added a commit that referenced this issue Apr 4, 2022
@tugcekucukoglu
Merge pull request #2392 from tugcekucukoglu/dialog
7613301 
Fixed #2381 - ConfirmDialog: 'position' TypeScript errors
@tugcekucukoglu tugcekucukoglu modified the milestones: 3.12.4, 3.12.5 Apr 4, 2022
@tugcekucukoglu tugcekucukoglu mentioned this issue Apr 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tugcekucukoglu tugcekucukoglu

Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
3.12.5
Development

No branches or pull requests
2 participants
@tugcekucukoglu @CA-Drew