Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calendar: inline calendar force scroll into viewport when disabledDates changed #2803

Closed
BoYuanSu opened this issue Jul 25, 2022 · 1 comment
Closed

Calendar: inline calendar force scroll into viewport when disabledDates changed #2803

BoYuanSu opened this issue Jul 25, 2022 · 1 comment
Assignees
@tugcekucukoglu
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
3.17.0

Comments

@BoYuanSu
Copy link

BoYuanSu commented Jul 25, 2022 •
edited
Loading

Watch data months change will trigger updateFocus method.

when disabledDates changed, months will be recalculated, and trigger watch data to updateFocus

demo code please refer the last commit of this branch https://github.com/BoYuanSu/primevue/tree/demo-2798

bellow is demo gif

demo-bug

from #2798 pr

PrimeVue version

3.15.0

Vue version

3.x

Language

ES6

Build / Runtime

Vite
@BoYuanSu BoYuanSu added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Jul 25, 2022
@tugcekucukoglu tugcekucukoglu added this to the 3.16.2 milestone Aug 22, 2022
@tugcekucukoglu tugcekucukoglu self-assigned this Aug 22, 2022
@tugcekucukoglu
Copy link
Member

#2798 points to the wrong issue number. If you create a new PR, we would gladly accept it.

@tugcekucukoglu tugcekucukoglu added the Resolution: Needs Revision The pull request can't be merged. Conflicts need to be corrected or documentation and code updated. label Aug 22, 2022
@tugcekucukoglu tugcekucukoglu removed this from the 3.16.2 milestone Aug 22, 2022
@BoYuanSu BoYuanSu mentioned this issue Aug 26, 2022
Merged
@tugcekucukoglu tugcekucukoglu removed the Resolution: Needs Revision The pull request can't be merged. Conflicts need to be corrected or documentation and code updated. label Sep 2, 2022
@tugcekucukoglu tugcekucukoglu added this to the 3.17.0 milestone Sep 2, 2022
tugcekucukoglu added a commit that referenced this issue Sep 2, 2022
@tugcekucukoglu
Merge pull request #2892 from BoYuanSu/master
a2596c9 
Fixed #2803 inline calendar autofocus when disabledDates changed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tugcekucukoglu tugcekucukoglu

Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
3.17.0
Development

No branches or pull requests
2 participants
@BoYuanSu @tugcekucukoglu