Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropdown: Cannot read properties of undefined (reading 'replaceAll') #2848

Closed
NeluQi opened this issue Aug 15, 2022 · 9 comments
Closed

Dropdown: Cannot read properties of undefined (reading 'replaceAll') #2848

NeluQi opened this issue Aug 15, 2022 · 9 comments
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@NeluQi
Copy link

NeluQi commented Aug 15, 2022

Describe the bug

image
image

image
image
image

After the update, all my Dropdowns were broken
It is difficult to say why this happened. I just upgraded prime

Moreover, even Dropdown in the DataTable broke. So it's probably my fault

Reproducer

No response

PrimeVue version

3.16.0

Vue version

3.x

Language

TypeScript

Build / Runtime

Vue CLI App

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response

@NeluQi NeluQi added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Aug 15, 2022
@S-le
Copy link

S-le commented Aug 16, 2022

You can set the 'selectionMessage' property with type String in primevue config.locale (locale: { selectionMessage: '' }). But I don't think this is a fix for production.

@tugcekucukoglu
Copy link
Member

While creating an issue, please share a codesandbox so we can replicate the issue.

@tugcekucukoglu tugcekucukoglu added Status: Pending Review Issue or pull request is being reviewed by Core Team and removed Type: Bug Issue contains a bug related to a specific component. Something about the component is not working labels Aug 16, 2022
@NeluQi
Copy link
Author

NeluQi commented Aug 16, 2022

While creating an issue, please share a codesandbox so we can replicate the issue.

It is very difficult to make a sandbox, because it is not even clear why this happened. I just updated prime and everything broke. I'll try to explore more soon, I'll write if possible

@NeluQi
Copy link
Author

NeluQi commented Aug 16, 2022

You can set the 'selectionMessage' property with type String in primevue config.locale (locale: { selectionMessage: '' }). But I don't think this is a fix for production.

It didn't solve the problem

image
image
image

@NeluQi
Copy link
Author

NeluQi commented Aug 16, 2022

Official codesandbox crashes when scrolling Virtual Scroll (1000 Items) and Lazy

image

https://codesandbox.io/s/i5zwyu

@NeluQi
Copy link
Author

NeluQi commented Aug 16, 2022

While creating an issue, please share a codesandbox so we can replicate the issue.

Alternatively, add a null check to filterResultMessageText

image
image

#2848 (comment)

@mertsincan mertsincan self-assigned this Aug 16, 2022
@mertsincan mertsincan added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Pending Review Issue or pull request is being reviewed by Core Team labels Aug 16, 2022
@mertsincan mertsincan added this to the 3.16.1 milestone Aug 16, 2022
@mertsincan
Copy link
Member

@NeluQi Thanks a lot for your report!

@NeluQi
Copy link
Author

NeluQi commented Aug 17, 2022

@mertsincan

If it was a matter of translations. Update the documentation page (add missing translation keys)
image

@tugcekucukoglu
Copy link
Member

Live updated https://www.primefaces.org/primevue/locale

Thanks,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

4 participants