Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dialog: Release mouse outside the dialog would close the dialog when dismissableMask is true. #6116

Closed
anchan42 opened this issue Jul 26, 2024 · 1 comment · Fixed by #6149 · May be fixed by nerds-github/litlyx#11
Closed

Dialog: Release mouse outside the dialog would close the dialog when dismissableMask is true. #6116

anchan42 opened this issue Jul 26, 2024 · 1 comment · Fixed by #6149 · May be fixed by nerds-github/litlyx#11
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
4.0.4

Comments

@anchan42
Copy link

anchan42 commented Jul 26, 2024 •
edited
Loading

Describe the bug

This cause wierd behavoir when there is a text box in the dialog. If user select text by dragging mouse across it and release mouse outside of the dialog, the dialog would be closed.

Reproducer

https://stackblitz.com/edit/primevue-3-vite-issue-template-dxjbyc?file=src%2FApp.vue

PrimeVue version

3.53

Vue version

3.x

Language

ES6

Build / Runtime

Vite

Browser(s)

Chrome latest

Steps to reproduce the behavior

Select text in user name input box by dragging mouse over it and release mouse outside dialog.

Expected behavior

The dialog should not be closed unless the user click outside the dialog.
I.e. mouse down inside the dialog and mouse up outside should not trigger onMaskClick event.
@anchan42 anchan42 added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jul 26, 2024
avramz added a commit to avramz/primevue that referenced this issue Jul 30, 2024
@avramz
- fix: primefaces#6116 prevent dialog from closing when releasing mou…
cf01b11 
…se outside the dialog and dismissableMask is set to true
@avramz avramz mentioned this issue Jul 30, 2024
Merged
tugcekucukoglu added a commit that referenced this issue Aug 1, 2024
@tugcekucukoglu
Merge pull request #6149 from avramz/dialog
655798b 
- fix: #6116 prevent dialog from closing when releasing mouse outside…
@tugcekucukoglu tugcekucukoglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Aug 1, 2024
@tugcekucukoglu tugcekucukoglu added this to the 4.0.4 milestone Aug 1, 2024
@anchan42
Copy link
Author

anchan42 commented Aug 2, 2024

Would we update the v3 to include this fix?

@nerds-github nerds-github mentioned this issue Oct 27, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
4.0.4
2 participants
@anchan42 @tugcekucukoglu