Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Select: v-tooltip does not work #6443

Closed
Pgolik opened this issue Sep 20, 2024 · 1 comment · Fixed by #6509
Closed

Select: v-tooltip does not work #6443

Pgolik opened this issue Sep 20, 2024 · 1 comment · Fixed by #6509
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
4.1.0

Comments

@Pgolik
Copy link

Pgolik commented Sep 20, 2024

Describe the bug

When using v-tooltip over Select component it crashes with TypeError: Cannot set properties of null (setting '$_ptooltipModifiers')

Reproducer

https://stackblitz.com/edit/primevue-4-vite-issue-template-mclxhx?file=src%2FApp.vue

PrimeVue version

4.0.4

Vue version

4.x

Language

TypeScript

Build / Runtime

Vue CLI App

Browser(s)

Chrome 128.0.6613.138

Steps to reproduce the behavior

  1. Go to main page
  2. Move cursor on select component
  3. Wait for tooltip to appear

Expected behavior

Tooltip appear with provided texts.
@Pgolik Pgolik added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Sep 20, 2024
@avramz avramz mentioned this issue Oct 1, 2024
Merged
@avramz
Copy link
Contributor

avramz commented Oct 1, 2024 •
edited
Loading

Can reproduce, the issue was that the getTarget method in Tooltip.js was not handling a null value which can be returned from findSingle fn call. Fix in PR.

@tugcekucukoglu tugcekucukoglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Oct 2, 2024
@tugcekucukoglu tugcekucukoglu added this to the 4.1.0 milestone Oct 2, 2024
tugcekucukoglu added a commit that referenced this issue Oct 2, 2024
@tugcekucukoglu
Merge pull request #6509 from avramz/fix/tooltip
f247f28 
#6443 fix: v-tooltip -> getTarget: Correctly fallback to el when find…
This was referenced Nov 11, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
4.1.0
Development

Successfully merging a pull request may close this issue.

#6443 fix: v-tooltip -> getTarget: Correctly fallback to el when find… avramz/primevue
4 participants
@avramz @Pgolik @tugcekucukoglu and others