Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #1596 : Typescript Plugin issue of ConfirmationService.d.ts and ToastService.d.ts #1595

Merged

Conversation

yichunsung
Copy link
Contributor

@yichunsung yichunsung commented Sep 22, 2021

The issue ( #1596 ) when using typescript in vue-tsc --noEmit && vite build

package version:

  • "vue": "^3.2.6"
  • "vite": "^2.5.2"
  • "vue-tsc": "^0.2.2"

if using vue-tsc --noEmit, it not working with these error.

Error message

node_modules/primevue/confirmationservice/ConfirmationService.d.ts:1:15 - error TS2305: Module '"vue"' has no exported member 'PluginFunction'.

import Vue, { PluginFunction } from 'vue';
                ~~~~~~~~~~~~~~

node_modules/primevue/toastservice/ToastService.d.ts:1:15 - error TS2305: Module '"vue"' has no exported member 'PluginFunction'.

import Vue, { PluginFunction } from 'vue';
                ~~~~~~~~~~~~~~

@yichunsung yichunsung changed the title Fixed ts Plugin issue of ConfirmationService.d.ts and ToastService.d.ts Fixed #1596 : Typescript Plugin issue of ConfirmationService.d.ts and ToastService.d.ts Sep 22, 2021
@PeterHewat
Copy link

PeterHewat commented Sep 30, 2021

Thanks @yichunsung,
I hope this PR gets accepted soon. I stumbled accross this exact same problem with

  • Vue 3.2.19
  • Vite 2.6.2
  • Vue-tsc 0.3.0
  • PrimeVue 3.7.2

@tugcekucukoglu tugcekucukoglu merged commit 2a5f242 into primefaces:master Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants