Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing 'expansion' slot TypeScript definition to DataTable.d.ts #1628

Merged

Conversation

samperumal
Copy link
Contributor

@samperumal samperumal commented Oct 2, 2021

The DataTable.d.ts file is missing the 'expansion' field in the $slots class field.
This PR adds the missing field.
This PR resolves Issue #1629

###Defect Fixes
When submitting a PR, please also create an issue documenting the error.

###Feature Requests
Due to company policy, we are unable to accept feature request PRs with significant changes as such cases has to be implemented by our team following our own processes.

The DataTable.d.ts is missing the 'expansion' field
in the $slots class field.
@samperumal samperumal marked this pull request as ready for review October 2, 2021 17:11
@tugcekucukoglu tugcekucukoglu merged commit 1f34b15 into primefaces:master Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants