Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breadcrumb accessibility improvment #2976

Merged
merged 4 commits into from
Sep 23, 2022
Merged

Breadcrumb accessibility improvment #2976

merged 4 commits into from
Sep 23, 2022

Conversation

bahadirsofuoglu
Copy link
Contributor

No description provided.

@bahadirsofuoglu bahadirsofuoglu mentioned this pull request Sep 15, 2022
Closed
@tugcekucukoglu tugcekucukoglu added Status: Pending Review Issue or pull request is being reviewed by Core Team Component: Accessibility Issue or pull request is related to WCAG or ARIA labels Sep 19, 2022
tugcekucukoglu
tugcekucukoglu reviewed Sep 19, 2022
View reviewed changes
Copy link
Member

@tugcekucukoglu tugcekucukoglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • nav element still have aria-label attribute
  • missing role navigation
  • separators does not have aria-hidden attribute
  • only last items has aria-current attribute, all list items should have this

@tugcekucukoglu tugcekucukoglu merged commit 5ef0a1a into primefaces:master Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tugcekucukoglu tugcekucukoglu tugcekucukoglu left review comments

Assignees
No one assigned
Labels
Component: Accessibility Issue or pull request is related to WCAG or ARIA Status: Pending Review Issue or pull request is being reviewed by Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bahadirsofuoglu @tugcekucukoglu