Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Timeline Implementation for Accessibility #3297

Merged
merged 2 commits into from
Nov 24, 2022
Merged

Improve Timeline Implementation for Accessibility #3297

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d04425f
Docs added
bahadirsofuoglu Nov 18, 2022
efe1503
doc fix
tugcekucukoglu Nov 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions src/views/timeline/TimelineDoc.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,6 +291,13 @@ export default {
</table>
</div>

<h5>Accessibility</h5>
<h6>Screen Reader</h6>
<p>Timeline uses a semantic ordered list element to list the events. No specific role is enforced, still you may use any aria role and attributes as any valid attribute is passed to the list element.</p>

<h6>Keyboard Support</h6>
<p>Component does not include any interactive elements.</p>

<h5>Dependencies</h5>
<p>None.</p>
</AppDoc>
Expand Down Expand Up @@ -440,7 +447,7 @@ export default {
::v-deep(.customized-timeline) {
.p-timeline-event:nth-child(even) {
flex-direction: row !important;

.p-timeline-event-content {
text-align: left !important;
}
Expand Down Expand Up @@ -598,7 +605,7 @@ export default {
::v-deep(.customized-timeline) {
.p-timeline-event:nth-child(even) {
flex-direction: row !important;

.p-timeline-event-content {
text-align: left !important;
}
Expand Down Expand Up @@ -764,7 +771,7 @@ export default {
.customized-timeline .p-timeline-event:nth-child(even) {
flex-direction: row !important;
}

.customized-timeline .p-timeline-event:nth-child(even) .p-timeline-event-content {
text-align: left !important;
}
Expand Down