Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update type for the column node that used props instead of $props #3423

Merged

Conversation

volvachev
Copy link
Contributor

@volvachev volvachev commented Dec 19, 2022

Fixes #3395

@tugcekucukoglu
Copy link
Member

This PR resolves the issue. But it has conflicts and the team decided not to use declare type, in these circumstances if you could update this PR, we gratefully accept it.

@volvachev volvachev force-pushed the fix-update-type-for-column-node-new branch from a1899de to ce55227 Compare April 11, 2023 19:14
@vercel
Copy link

vercel bot commented Apr 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
primevue ⬜️ Ignored (Inspect) Apr 11, 2023 7:14pm

@volvachev
Copy link
Contributor Author

This PR resolves the issue. But it has conflicts and the team decided not to use declare type, in these circumstances if you could update this PR, we gratefully accept it.

Hi, i updated pr.

@mertsincan mertsincan added the Status: Pending Review Issue or pull request is being reviewed by Core Team label Sep 5, 2023
@mertsincan mertsincan added this to the 3.33.1 milestone Sep 5, 2023
@tugcekucukoglu tugcekucukoglu modified the milestones: 3.33.1, 3.33.2, 3.34.1, 3.34.2 Sep 5, 2023
@tugcekucukoglu tugcekucukoglu modified the milestones: 3.35.0, 3.35.1 Sep 26, 2023
@mertsincan mertsincan removed the Status: Pending Review Issue or pull request is being reviewed by Core Team label Oct 5, 2023
@mertsincan
Copy link
Member

Thanks a lot for your contribution!

Best Regards,

@mertsincan mertsincan merged commit b09a50d into primefaces:master Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DataGrid: Invalid typing of slot props
3 participants