fix: fix the unexpected behavior of the ConfirmDialog popup #4252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in-top and margin-left
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Dmytro-Lukashenko
changed the title
|
Hi @tugcekucukoglu. The main problem is in the Dialog component logic. But other components that extend Dialog have the same problem. |
|
Hi @melloware, @cagataycivici, @tugcekucukoglu, @mertsincan, @bahadirsofuoglu, @yigitfindikli, @Merve7, @onursenture, @atakantepe. Guys, could you please check out this bug? We use the amazing Primevue library in our project and we need to fix it. Thanks. Happy coding! |
This was referenced Aug 12, 2023
melloware
suggested changes
Aug 14, 2023
melloware
approved these changes
Aug 14, 2023
|
Hi @melloware. Could you please merge this PR? |
|
Thanks a lot for your contribution! Best Regards, |
This was referenced Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4251
This issue linked to the fixes for PrimeNg and PrimeReact
p-dialogbad drag behavior primeng#13493 - Prime Ng