Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataTable in expand mode resizing problem #4276

Merged
merged 3 commits into from
Aug 17, 2023

Conversation

1Map
Copy link
Contributor

@1Map 1Map commented Aug 16, 2023

Fix #4277

###Defect Fixes

Steps to reproduce the behavior
go to https://primevue.org/datatable/#resize_expandmode
go to the section labelled 'Expand Mode'
Use your mouse to drag the right side of the 'Name' column an inch to the right
Actual: The Code column and also the other columns after Name also changes size slightly. Not by as much as you resize the Name column, but it always changes, and it changes more if you resize Name more. This also happens for any other column aside from the first one. The end result is the column doesn't end up where you dragged it.

This only seems to be a problem with Expand Mode -- Fit mode works correctly.

Expected behavior
Name column resized to the exact spot where you dragged it, all other columns to the right shifted by that amount but not resized, all other columns to the left untouched.

@vercel
Copy link

vercel bot commented Aug 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
primevue ⬜️ Ignored (Inspect) Visit Preview Aug 17, 2023 1:20pm

@melloware
Copy link
Member

This was ported from PrimeReact where it was tested there.

@tugcekucukoglu
Copy link
Member

Please create an issue with reproducing link while submitting a PR.

@tugcekucukoglu tugcekucukoglu added the Resolution: Needs Revision The pull request can't be merged. Conflicts need to be corrected or documentation and code updated. label Aug 16, 2023
@1Map
Copy link
Contributor Author

1Map commented Aug 16, 2023

Please create an issue with reproducing link while submitting a PR.

@tugcekucukoglu If you have a look you will see that there is already a link to the issue above:

#4277

@melloware
Copy link
Member

@1Map in your comment in the first post if you say it like this

Fix #4277

with the word "Fix" in front of it it automatically links this PR with the ticket!

Copy link
Contributor Author

@1Map 1Map left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review and approve

@melloware
Copy link
Member

@1Map you can see this fixed in PrimeReact showcase now: https://primereact.org/datatable/#resize_expandmode

@1Map
Copy link
Contributor Author

1Map commented Aug 17, 2023

@1Map you can see this fixed in PrimeReact showcase now: https://primereact.org/datatable/#resize_expandmode

Thanks, problem is that I am using PrimeVue and there it is still not fixed.

@melloware
Copy link
Member

I understand but you were wondering why it wasn't fixed in PrimeReact it just that the showcase was not deployed.

@tugcekucukoglu tugcekucukoglu removed the Resolution: Needs Revision The pull request can't be merged. Conflicts need to be corrected or documentation and code updated. label Aug 17, 2023
@tugcekucukoglu tugcekucukoglu merged commit 77a6fc2 into primefaces:master Aug 17, 2023
1 check failed
@tugcekucukoglu
Copy link
Member

@1Map you can see this fixed in PrimeReact showcase now: https://primereact.org/datatable/#resize_expandmode

Thanks, problem is that I am using PrimeVue and there it is still not fixed.

I understand the passion we all have for this project and it is important for us to work together effectively. I must admit that I was initially quite disturbed by the rudeness of this comment. I don't see anything wrong with us having open discussions and considering different points of view before finalizing any changes and I will continue to take this approach.

As for your question, the showcase will be updated when 3.32.1 is released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DataTable in expand mode resizing problem
3 participants