Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #4568: Add missing message property on ToastProps type #4569

Merged
merged 1 commit into from
Oct 8, 2023
Merged

Fix #4568: Add missing message property on ToastProps type #4569

merged 1 commit into from
Oct 8, 2023

Conversation

JakeMinor
Copy link
Contributor

@JakeMinor JakeMinor commented Oct 6, 2023

Fix #4568: Adds type support to allow access to message props in Toasts by adding the message property to the ToastProps type.

@vercel
Copy link

vercel bot commented Oct 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
primevue ⬜️ Ignored (Inspect) Oct 6, 2023 5:15pm

@FlipWarthog
Copy link
Contributor

@JakeMinor If you edit the title of this PR and prepend it with "Fix #4568: ", it should automatically link it to the issue. Maybe also need to start the description with "Fix #4568: " as well, I'm not sure.

@JakeMinor JakeMinor changed the title Add missing message property on ToastProps type Fix #4568: Add missing message property on ToastProps type Oct 6, 2023
@JakeMinor
Copy link
Contributor Author

JakeMinor commented Oct 6, 2023

Just for future reference, it appears to be the description which links the issue :)

@mertsincan
Copy link
Member

Thanks a lot for your contribution!

Best Regards,

@mertsincan mertsincan merged commit 01e3fe7 into primefaces:master Oct 8, 2023
1 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Toast: Message prop is missing from ToastProps type
3 participants