fix: fix the unexpected joggle state when dialog component non-fixed
#6161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
tugcekucukoglu
added
the
Resolution: Help Wanted
|
Cannot be merged due to conflicts. Can be merged when conflicts are resolved. |
…non-fixed # Conflicts: # packages/primevue/src/dialog/Dialog.vue
Hi~~~ Conflicts resolved~ 😉 |
tugcekucukoglu
approved these changes
Aug 22, 2024
LeaderbotX400
pushed a commit
to LeaderbotX400/primevue
that referenced
this pull request
Aug 29, 2024
This was referenced Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defect Fixes
For fixing the issue in
primevue v4: #6160When the dom is not fully
entered, triggering thefocusevent will cause the browser force to settle the doms. So we may need to postpone thefocusevent.