feature: Add Adyen Blik to Headless #1005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borisprimer
changed the title
borisprimer
force-pushed
the
bn/ACC-4219-adyen-blik-on-headless
branch
from
3facac6 to
46bd9c9
Compare
|
Appetize link: https://appetize.io/app/wadz533rcnu4zd6skwtg2l6dga |
marjaimate
reviewed
Sep 30, 2024
| redirectManager = try PrimerHeadlessUniversalCheckout.NativeUIManager(paymentMethodType: paymentMethodType) | ||
| try redirectManager?.showPaymentMethod(intent: sessionIntent) | ||
| } catch { | ||
| print("\n\nMERCHANT APP\n\(#function)\nerror: \(error)") |
There was a problem hiding this comment.
@BorisNikolic do we need to send analytics data, or logs at this point to Kibana?
There was a problem hiding this comment.
Actually no need, this is the debug app code, the view controller utilising headless implementation as an example.
Will do that, totally forgot to add them 🤦 |
borisprimer
force-pushed
the
bn/ACC-4219-adyen-blik-on-headless
branch
4 times, most recently
from
79ee26c to
590dbe7
Compare
Generated by 🚫 Danger Swift against 0d00a77 |
NQuinn27
reviewed
Oct 3, 2024
Package.resolved
Outdated
There was a problem hiding this comment.
Would you expect this addition here?
NQuinn27
reviewed
Oct 3, 2024
|
|
||
| var rawData: PrimerRawData? { | ||
| didSet { | ||
| if let rawPhoneNumberInput = self.rawData as? PrimerOTPData { |
There was a problem hiding this comment.
This variable name is a little misleading
There was a problem hiding this comment.
Fixed and pushed.
NQuinn27
previously approved these changes
Oct 3, 2024
borisprimer
force-pushed
the
bn/ACC-4219-adyen-blik-on-headless
branch
from
7f823d8 to
330fe24
Compare
borisprimer
force-pushed
the
bn/ACC-4219-adyen-blik-on-headless
branch
from
330fe24 to
0d00a77
Compare
|
NQuinn27
approved these changes
Oct 3, 2024
NQuinn27
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA