fix: Discover card network image not showing #1025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borisprimer
changed the title
Generated by 🚫 Danger Swift against 3af7237 |
|
Appetize link: https://appetize.io/app/rzrcdynts6am5fznhi3zwmnzmu |
|
NQuinn27
approved these changes
Oct 21, 2024
|
@BorisNikolic I wonder if we can add some tests (Unit?) which ensure that these enums produce a valid image? Fine to ticket for later - but would be good to try ensure this cant happen again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CHKT-4054
Name of the icon in the code was wrong so UIImage was NIL