Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Expose VaultedPaymentMethod initialiser #1032

Merged
merged 4 commits into from
Oct 24, 2024

Conversation

NQuinn27
Copy link
Contributor

@NQuinn27 NQuinn27 commented Oct 23, 2024

Description

CHKT-XXXX

  • Makes initialiser for VaultedPaymentMethod public.
  • Adds convenience initialiser for CardNetworkAsset from network string

Contributor Checklist

  • All status checks have passed prior to code review
  • I have added unit tests to a reasonable level of coverage where suitable
  • I have added UI tests to new user flows, if applicable
  • I have manually tested newly added UX
  • I have open a documentation PR, if applicable

Reviewer Checklist

  • I have verified that a suitable set of automated tests has been added
  • I have verified that the title prefix aligns to the code changes + whether a release is expected after merging the PR
  • I have verified the documentation PR aligns with this PR, if applicable

Before Merging

  • If introducing a breaking change, I have communicated it internally
  • Any related documentation PRs are ready to merge

Other Stuff

  • You can find out more about our automation checks here
  • Find out more about conventional commits here

@NQuinn27 NQuinn27 requested a review from a team as a code owner October 23, 2024 15:07
Copy link
Contributor

github-actions bot commented Oct 23, 2024

Warnings
⚠️ Please assign someone aside from CODEOWNERS (@checkout-pci-reviewers) to review this PR.

Generated by 🚫 Danger Swift against b548715

Copy link
Contributor

@NQuinn27 NQuinn27 requested a review from borisprimer October 23, 2024 19:36
@NQuinn27 NQuinn27 changed the title feat: Get vaulted card network asset based on token data fix: Expose VaultedPaymentMethod initialiser Oct 24, 2024
@NQuinn27 NQuinn27 requested a review from semirp October 24, 2024 05:37
Copy link

@borisprimer borisprimer merged commit b468157 into master Oct 24, 2024
15 of 18 checks passed
@borisprimer borisprimer deleted the nq/vaulted_payment_method_updates branch October 24, 2024 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants