Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Crash in InternalCardComponentsManager #1042

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

borisprimer
Copy link
Contributor

…ard expiration year and month

- Added guard clauses to ensure `expiryYear` and `currentYearAsString` have the expected format and length before constructing `cardExpirationYear`.
- Improved error handling in `tokenizationPaymentInstrument` to safely unwrap `expiryMonth` and `cardExpirationYear`.
- Enhanced resilience of card expiration year handling to prevent crashes due to invalid input formats.
@borisprimer borisprimer requested a review from NQuinn27 November 12, 2024 10:28
@borisprimer borisprimer self-assigned this Nov 12, 2024
@borisprimer borisprimer requested a review from a team as a code owner November 12, 2024 10:28
Copy link
Contributor

github-actions bot commented Nov 12, 2024

Warnings
⚠️ This PR doesn't seem to contain any updated Unit Test 🤔. Please consider double checking it.🙏

Generated by 🚫 Danger Swift against 712c873

Copy link
Contributor

@NQuinn27 NQuinn27 merged commit 79fdb43 into master Nov 13, 2024
14 checks passed
@NQuinn27 NQuinn27 deleted the fix/ACC-4516-InternalCardComponentsManager-crash branch November 13, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants