Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove precondition on presentPaymentMethod #1048

Merged
merged 2 commits into from
Nov 19, 2024
Merged

fix: Remove precondition on presentPaymentMethod #1048

merged 2 commits into from
Nov 19, 2024

Conversation

NQuinn27
Copy link
Contributor

@NQuinn27 NQuinn27 commented Nov 19, 2024 •
edited by jira bot
Loading

Description

ESC-202

  • Replaces the precondition with a logged error and graceful failure

@NQuinn27 NQuinn27 requested a review from a team as a code owner November 19, 2024 10:30
@NQuinn27 NQuinn27 requested a review from borisprimer November 19, 2024 10:31
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 19, 2024 •
edited
Loading

Warnings
⚠️ This PR doesn't seem to contain any updated Unit Test 🤔. Please consider double checking it.🙏
⚠️ Please assign someone aside from CODEOWNERS (@checkout-pci-reviewers) to review this PR.

Generated by 🚫 Danger Swift against 2973e61

borisprimer
borisprimer previously approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@borisprimer borisprimer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good, just some SwiftLint warnings

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
46.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions GitHub Actions
Copy link
Contributor

Appetize link: https://appetize.io/app/i5est6cmjho4a7gkr4a7kukevy

@NQuinn27 NQuinn27 merged commit 668f9ed into master Nov 19, 2024
14 checks passed
@NQuinn27 NQuinn27 deleted the nq/remove_precondition branch November 19, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@borisprimer borisprimer borisprimer approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NQuinn27 @borisprimer