chore: Add Klarna Dependency to Package.swift #1053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -6,42 +6,44 @@ let package = Package( | |||
| name: "PrimerSDK", | |||
| defaultLocalization: "en", | |||
| platforms: [ | |||
| .iOS("13.1") | |||
| .iOS("13.1"), | |||
There was a problem hiding this comment.
⚠️ Collection literals should not have trailing commas. (trailing_comma)
| ], | ||
| products: [ | ||
| .library( | ||
| name: "PrimerSDK", | ||
| targets: ["PrimerSDK"] | ||
| ) | ||
| ), |
There was a problem hiding this comment.
⚠️ Collection literals should not have trailing commas. (trailing_comma)
| ], | ||
| dependencies: [ | ||
| .package(url: "https://github.com/primer-io/primer-sdk-3ds-ios", from: "2.4.1") | ||
| .package(url: "https://github.com/primer-io/primer-sdk-3ds-ios", from: "2.4.1"), | ||
| .package(url: "https://github.com/primer-io/primer-klarna-sdk-ios", from: "1.1.2"), |
There was a problem hiding this comment.
⚠️ Collection literals should not have trailing commas. (trailing_comma)
| ], | ||
| targets: [ | ||
| .target( | ||
| name: "PrimerSDK", | ||
| dependencies: [ | ||
| .product(name: "Primer3DS", package: "primer-sdk-3ds-ios") | ||
| .product(name: "Primer3DS", package: "primer-sdk-3ds-ios"), | ||
| .product(name: "PrimerKlarnaSDK", package: "primer-klarna-sdk-ios"), |
There was a problem hiding this comment.
⚠️ Collection literals should not have trailing commas. (trailing_comma)
| ], | ||
| path: "Sources/PrimerSDK", | ||
| resources: [ | ||
| .process("Resources"), | ||
| .copy("Classes/Third Party/PromiseKit/LICENSE") | ||
| .copy("Classes/Third Party/PromiseKit/LICENSE"), |
There was a problem hiding this comment.
⚠️ Collection literals should not have trailing commas. (trailing_comma)
| ] | ||
| ), | ||
| .testTarget( | ||
| name: "Tests", | ||
| dependencies: [ | ||
| .product(name: "Primer3DS", package: "primer-sdk-3ds-ios"), | ||
| .byName(name: "PrimerSDK") | ||
| .byName(name: "PrimerSDK"), |
There was a problem hiding this comment.
⚠️ Collection literals should not have trailing commas. (trailing_comma)
| ], | ||
| path: "Tests/", | ||
| sources: [ | ||
| "3DS/", | ||
| "Utilities/", | ||
| "Primer/" | ||
| "Primer/", |
There was a problem hiding this comment.
⚠️ Collection literals should not have trailing commas. (trailing_comma)
| ] | ||
| ) | ||
| ), |
There was a problem hiding this comment.
⚠️ Collection literals should not have trailing commas. (trailing_comma)
Generated by 🚫 Danger Swift against 417a312 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
DO NOT MERGE - PR for visibility
We need to add the Klarna dependency as a merchant requires for iminent go-live. Currently SPM optional dependencies are incompatible with the runtime checks we perform to determine inclusion.
The need to do this is temporary, please see this ticket: ACC-4586 for a path to overcoming this need.
I expect to implement the fixes in the coming weeks.