fix: Validate PENDING in resume if showSuccessCheckoutOnPendingPayment flag is true #957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger Swift against 133300d |
|
Appetize link: https://appetize.io/app/7fgmcxivdlkku5mrw243plzlpu |
jnewc
approved these changes
Aug 5, 2024
Sources/PrimerSDK/Classes/Core/Payment Services/CreateResumePaymentService.swift
Outdated
Show resolved
Hide resolved
|
NQuinn27
force-pushed
the
nq/respect_pending_success_flag
branch
from
f609972 to
133300d
Compare
NQuinn27
added a commit
that referenced
this pull request
Aug 7, 2024
…t flag is true (#957) * Validate PENDING in resume if flag is true * Remove unused code * Added unit tests for CreateResumeService * Make new flag a bool * Added strings for fintechture * Remove redundant enum * Split out createresume into seperate protocol
NQuinn27
added a commit
that referenced
this pull request
Aug 8, 2024
* Added poc of config caching * Extend network service to bubble up headers when wanted * Dont utilise headers in klarna configs * Added Swift-friendly Cache * Refactored caching logic to dedicated class * use refactored cache * Extract ttl from headers * Process images also for actions * Upgrade config endpoints to 2.3 * Add config cache tests * Fix tests for new interface * update fallback to 0 * add tests for config module * Add responses to mocks * Formatting: Update ConfigurationCache.swift * Formatting: Update PrimerAPIConfigurationModule.swift * Formatting: Update PrimerAPIConfigurationModule.swift * Formatting: Update DefaultNetworkService.swift * Formatting: Update NetworkService.swift * Clear cache after tests * Update apiVersion in tests * Added events for loading * Clear cache on cleanup * Add checkout session active * Record load of vault manager * Record headless loading event * fix: Validate PENDING in resume if showSuccessCheckoutOnPendingPayment flag is true (#957) * Validate PENDING in resume if flag is true * Remove unused code * Added unit tests for CreateResumeService * Make new flag a bool * Added strings for fintechture * Remove redundant enum * Split out createresume into seperate protocol * Fix conflicts * Release 2.28.0 (#963) [create-pull-request] automated change Co-authored-by: NQuinn27 <3179752+NQuinn27@users.noreply.github.com> * Add clientSessionCachingEnabled flag * Add unit test to test for flag * move cache clean to cleanup * Implement LogReporter * Fix use cached config test --------- Co-authored-by: Security Integrations <security-integrations@primer.io> Co-authored-by: NQuinn27 <3179752+NQuinn27@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR respects the
showSuccessCheckoutOnPendingPaymentflag when validating Payment response on the/resumecall.PENDINGandshowSuccessCheckoutOnPendingPaymentisfalse, we will throw the payment failed error, as we would if the state wasFAILEDPENDINGandshowSuccessCheckoutOnPendingPaymentistrue, we will continue on the success pathManual Testing
Test with Fintechture as outlined here
Screenshots
If applicable, otherwise remove this section
Contributor Checklist
Reviewer Checklist
Before Merging
Other Stuff