Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to v9 primitives #717

Merged
merged 18 commits into from
Aug 28, 2024
Merged
Show file tree
Hide file tree
Changes from 17 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions .changeset/cold-items-try.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
---
'@primer/react-brand': minor
---

Improved a11y labelling in various components.

Please note these changes could affect any behavioral tests, which rely on accessible matchers such as `getByRole`.

- `SubdomainNavBar` search button `aria-label` changed from 'search' to 'Toggle search bar'
- `SubdomainNavBar` removal of unnecessary `aria-label` 'global breadcrumb'
- `Checkbox` addition of new label for `checked` state icon as 'Checkmark'
- `Checkbox` addition of new label for `indeterminate` state icon as 'Dash icon'
25 changes: 25 additions & 0 deletions .changeset/lovely-timers-visit.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
---
'@primer/brand-primitives': minor
---

Change to `xxlarge` breakpoint and the addition of two new base scale size tokens.

Outcome of an upgrade to Primer Primitives `v9` release.

```diff
+ --base-size-2: 0.125rem;
```

```diff
+ --base-size-6: 0.375rem;
```

```diff
- --brand-breakpoint-xxlarge: 90rem;
+ --brand-breakpoint-xxlarge: 87.5rem;
```

```diff
- @custom-media --brand-viewportRange-wide-viewport (min-width: 90rem);
+ @custom-media --brand-viewportRange-wide-viewport (min-width: 87.5rem);
```
2 changes: 1 addition & 1 deletion .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@ module.exports = {
allow: ['dark_dimmed'],
},
],
'primer-react/no-deprecated-colors': ['warn', {checkAllStrings: true}],
},
overrides: [
// rules which apply only to JS
Expand Down Expand Up @@ -170,6 +169,7 @@ module.exports = {
'@typescript-eslint/no-unnecessary-condition': 0,
'@typescript-eslint/no-unused-vars': 0,
'no-redeclare': 0,
'github/a11y-svg-has-accessible-name': 0,
},
},
// rules which apply only to Figma code connect files
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ui_test_primitives_diff.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ jobs:

- name: Export diff
run: |
diff -r -y --width=300 -B -I '*' -I 'Generated' --suppress-common-lines temp-main/packages/design-tokens/lib/design-tokens/css packages/design-tokens/lib/design-tokens/css | tail -n +2 > diff.txt
diff -r -y --width=300 -B -I 'Generated' --suppress-common-lines temp-main/packages/design-tokens/lib/design-tokens/css packages/design-tokens/lib/design-tokens/css | tail -n +2 > diff.txt
npx ts-node ./packages/design-tokens/scripts/ci-check-diff.ts

- name: Read raw diff
Expand Down
Loading
Loading